fix dangling reference in parser::Parse

solo-io · Mar 15, 2024 · 933febc · 933febc
1 parent 0066e60
commit 933febc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/include/inja/parser.hpp b/include/inja/parser.hpp
@@ -29,6 +29,7 @@ class Parser {
 
   Lexer lexer;
   TemplateStorage& template_storage;
+  std::vector<Template> template_stash;
   const FunctionStorage& function_storage;
 
   Token tok, peek_tok;
@@ -621,7 +622,7 @@ class Parser {
       : config(parser_config), lexer(lexer_config), template_storage(template_storage), function_storage(function_storage) {}
 
   Template parse(std::string_view input, std::string_view path) {
-    auto result = Template(static_cast<std::string>(input));
+    auto& result = template_stash.emplace_back(Template(static_cast<std::string>(input)));
     parse_into(result, path);
     return result;
   }

diff --git a/single_include/inja/inja.hpp b/single_include/inja/inja.hpp
@@ -1441,6 +1441,7 @@ class Parser {
 
   Lexer lexer;
   TemplateStorage& template_storage;
+  std::vector<Template> template_stash;
   const FunctionStorage& function_storage;
 
   Token tok, peek_tok;
@@ -2033,7 +2034,7 @@ class Parser {
       : config(parser_config), lexer(lexer_config), template_storage(template_storage), function_storage(function_storage) {}
 
   Template parse(std::string_view input, std::string_view path) {
-    auto result = Template(static_cast<std::string>(input));
+    auto& result = template_stash.emplace_back(Template(static_cast<std::string>(input)));
     parse_into(result, path);
     return result;
   }