allow overriding stat name via Upstream label #10654
Open
+55
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenctl
force-pushed
the
stevenctl/stat-name-override
branch
from
fb99f7f to
14f10b9
Compare
stevenctl
commented
Feb 24, 2025
| Entry("non-kube upstream", createStaticUpstream("name", "ns", nil), "name_ns"), | ||
| Entry("non-kube upstream", createStaticUpstream("name", "ns", map[string]string{ | ||
| translator.ClusterStatNameLabel: translator.FormatClusterStatName("istio-se_", "usname", "usns", "svcns", "svcName", 123), | ||
| }), "istio-se_usname_usns_svcns_svcName_123"), |
There was a problem hiding this comment.
@krisztianfekete can you spot check this output would be correctly parsed
jenshu
reviewed
Feb 24, 2025
jenshu
reviewed
Feb 24, 2025
| changelog: | ||
| - type: NON_USER_FACING | ||
| description: >- | ||
| Allow using the label `~internal.solo.io/cluster-stat-name` to manually set |
There was a problem hiding this comment.
Suggested change
| Allow using the label `~internal.solo.io/cluster-stat-name` to manually set | |
| Allow using the label `internal.solo.io/cluster-stat-name` to manually set |
There was a problem hiding this comment.
Just changed the actual label. I think we want the ~, otherwise any user in any namespace could break the metric for any service in any other namespace.
jenshu
reviewed
Feb 24, 2025
| const ClusterStatNameLabel = "internal.solo.io/cluster-stat-name" | ||
|
|
||
| // FormatClusterStatName produces a parseable alt_stat_name. | ||
| func FormatClusterStatName( |
There was a problem hiding this comment.
do we need to export this? will it be used externally? (besides in the translator test)
There was a problem hiding this comment.
I may use it in solo-projects. I technically don't have to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow using the label
~internal.solo.io/cluster-stat-nameto manually set the alt_stat_name on the Envoy cluster that will result from an Upstream. This allows synthetic Upstreams to specify parseable alt_stat_name.API changes
(Internal) ~internal.solo.io/cluster-stat-name can be set from code that generates Upstream synthetically. The ~ prevents users from setting this label and hijacking some services stats.
Code changes
Context
ServiceEntry support that will eventually land in kgateway, but we want it to produce parseable stat names in the near terrm.