-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiarch updates #10421
multiarch updates #10421
Conversation
Visit the preview URL for this PR (updated for commit c3f6250): https://gloo-edge--pr10421-rav-multiarch-qui1uu1b.web.app (expires Tue, 10 Dec 2024 16:12:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
ci/cloudbuild/publish-artifacts.yaml
Outdated
@@ -43,16 +43,37 @@ steps: | |||
- 'compute/zone' | |||
- 'us-central1-a' | |||
|
|||
# Initialize Docker Buildx for multi-platform builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the execution of this job is commented out above, would be good to see this succeed in a test run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry missed this, execution commented out as in ?
/kick "re-run failed CI cloudbuild" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. I know there will be some follow ups but its a great start!
Co-authored-by: sheidkamp <seth.heidkamp@gmail.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
Description
This PR adds preliminary work for building multiarch images
nightly tests runs:
https://github.com/solo-io/gloo/actions/runs/12162387255
https://github.com/solo-io/gloo/actions/runs/12142343463
CI changes
distroless-docker, distroless-with-utils-docker, certgen, certgen-distroless, kubectl, kubectl-dtstroless
Testing steps
Notes for reviewers
Checklist: