Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiarch updates #10421

Merged
merged 28 commits into from
Dec 5, 2024
Merged

multiarch updates #10421

merged 28 commits into from
Dec 5, 2024

Conversation

rpunia1
Copy link

@rpunia1 rpunia1 commented Dec 2, 2024

Description

This PR adds preliminary work for building multiarch images

  • distroless base images have been updated to be multiarch (distroless-docker, distroless-with-utils-docker).
  • certgen & kubectl images are also updated to be multiarch.
  • Cloudbuilder CI build is updated to build/publish multiarch images for above ^
  • some 3rd party test images are also made multiarch (testrunner, http-echo, kennship-http-echo)

nightly tests runs:

https://github.com/solo-io/gloo/actions/runs/12162387255
https://github.com/solo-io/gloo/actions/runs/12142343463

CI changes

  • with this PR multiarch images are build and pushed for images
    distroless-docker, distroless-with-utils-docker, certgen, certgen-distroless, kubectl, kubectl-dtstroless

Testing steps

export VERSION=1.18.0-rc3
export MULTIARCH=true

make distroless-docker -B
make distroless-with-utils-docker -B
make certgen-docker -B
make certgen-distroless-docker -B
make kubectl-docker -B
make kubectl-distroless-docker -B

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

github-actions bot commented Dec 2, 2024

Visit the preview URL for this PR (updated for commit c3f6250):

https://gloo-edge--pr10421-rav-multiarch-qui1uu1b.web.app

(expires Tue, 10 Dec 2024 16:12:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@rpunia1 rpunia1 self-assigned this Dec 3, 2024
Copy link

@sheidkamp sheidkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

@@ -43,16 +43,37 @@ steps:
- 'compute/zone'
- 'us-central1-a'

# Initialize Docker Buildx for multi-platform builds

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the execution of this job is commented out above, would be good to see this succeed in a test run.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry missed this, execution commented out as in ?

@rpunia1
Copy link
Author

rpunia1 commented Dec 4, 2024

/kick "re-run failed CI cloudbuild"

@rpunia1 rpunia1 requested review from nfuden and sheidkamp December 4, 2024 17:36
Copy link
Collaborator

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I know there will be some follow ups but its a great start!

@nfuden nfuden added the enhancement New feature or request label Dec 5, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit 10e7739 into main Dec 5, 2024
51 of 53 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the rav/multiarch branch December 5, 2024 14:20
This was referenced Dec 5, 2024
kevin-shelaga pushed a commit that referenced this pull request Dec 13, 2024
Co-authored-by: sheidkamp <seth.heidkamp@gmail.com>
Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep pr updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants