1.17.x - delete internal api docs #10372
Conversation
…docs Delete internal API docs after generation
|
Issues linked to changelog: |
| @@ -66,7 +66,7 @@ and FilterChain configuration (MatchableHttpGateway CR) | |||
|
|
|||
| | Field | Type | Description | | |||
| | ----- | ---- | ----------- | | |||
| | `sourcePrefixRanges` | [[]solo.io.envoy.config.core.v3.CidrRange](../../../../gloo/api/external/envoy/config/core/v3/address.proto.sk/#cidrrange) | CidrRange specifies an IP Address and a prefix length to construct the subnet mask for a CIDR range. See https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/address.proto#envoy-v3-api-msg-config-core-v3-cidrrange. | | |||
There was a problem hiding this comment.
Is a change like this safe?
This CidrRange API is part of our public MatchableHttpGateway API, right? The fact that the API is an attempted mirror of an Envoy API is an implementation detail, but I would image we would still want users to have a link to the proto definition.
Am I missing something?
There was a problem hiding this comment.
There was a discussion of this here: https://solo-io-corp.slack.com/archives/C03MFATU265/p1731608037978029?thread_ts=1731598700.372589&cid=C03MFATU265
with a follow-up issue to restore the links created: kgateway-dev#10349
After I'm done the licensing ticket, I'll take a look to see if that can be done quickly.
Description
Backport of kgateway-dev#10334