This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Let the new coded exceptions from codecs-core bubble up as-is through @solana/options et al
#2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
This was referenced Mar 4, 2024
buffalojoec
approved these changes
Mar 4, 2024
lorisleiva
approved these changes
Mar 4, 2024
steveluscher
force-pushed
the
03-04-Reorganize_codec_errors_into_error_code_range_8078000-8078999_
branch
from
f528a09 to
bb38bb1
Compare
steveluscher
force-pushed
the
03-04-Let_the_new_coded_exceptions_from_codecs-core_bubble_up_as-is_through_solana/options_
branch
from
de2848a to
f7dd0d1
Compare
steveluscher
changed the title
codecs-core bubble up as-is through @solana/optionscodecs-core bubble up as-is through @solana/options et al
Done, in this PR! |
steveluscher
force-pushed
the
03-04-Reorganize_codec_errors_into_error_code_range_8078000-8078999_
branch
from
bb38bb1 to
e4634c5
Compare
steveluscher
force-pushed
the
03-04-Let_the_new_coded_exceptions_from_codecs-core_bubble_up_as-is_through_solana/options_
branch
from
f7dd0d1 to
ea29eaa
Compare
Merge activity
|
Base automatically changed from
03-04-Reorganize_codec_errors_into_error_code_range_8078000-8078999_
to
master
March 4, 2024 20:41
…gh `@solana/options`
steveluscher
force-pushed
the
03-04-Let_the_new_coded_exceptions_from_codecs-core_bubble_up_as-is_through_solana/options_
branch
from
ea29eaa to
9a1834c
Compare
steveluscher
deleted the
03-04-Let_the_new_coded_exceptions_from_codecs-core_bubble_up_as-is_through_solana/options_
branch
|
🎉 This PR is included in version 1.91.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The developer will receive a
SOLANA_ERROR__CODECS_EXPECTED_FIXED_LENGTH_GOT_VARIABLE_LENGTHand should be able to determine which thing was of the wrong type based on the line that threw that error. I don't think we need to rethrow/respecify the error here.Addresses #2118.