This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Convert errors in @solana/signers to coded exceptions
#2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
commented
Feb 29, 2024
packages/errors/src/context.ts
Outdated
| }; | ||
| [SOLANA_ERROR__SIGNER_EXPECTED_CONFORMING_SIGNER]: { | ||
| address: string; | ||
| interfaceName: string; |
There was a problem hiding this comment.
Not super sure that this was the right thing to do, but you tell me @lorisleiva.
There was a problem hiding this comment.
I think it'd be nicer to have one for each type. Because otherwise there is redundancy between the "expected conforming signer" error and "expected transaction signer" error.
steveluscher
changed the base branch from
master
to
03-01-Refine_Address_error_types
steveluscher
force-pushed
the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
from
24cb64d to
b6c80ed
Compare
steveluscher
force-pushed
the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
from
b6c80ed to
f0ad0e1
Compare
steveluscher
force-pushed
the
03-01-Refine_Address_error_types
branch
from
34d5666 to
b59fecd
Compare
steveluscher
force-pushed
the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
from
f0ad0e1 to
75de449
Compare
steveluscher
force-pushed
the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
from
75de449 to
e14a7ef
Compare
steveluscher
force-pushed
the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
from
e14a7ef to
3b46917
Compare
Merge activity
|
steveluscher
deleted the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
|
🎉 This PR is included in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2118.