This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 932
Rename all transaction/airdrop sender factories with the ‘Factory’ suffix #2130
Merged
steveluscher
merged 1 commit into
master
from
02-16-Rename_all_transaction/airdrop_sender_factories_with_the_Factory_suffix
Feb 20, 2024
Merged
Rename all transaction/airdrop sender factories with the ‘Factory’ suffix #2130
steveluscher
merged 1 commit into
master
from
02-16-Rename_all_transaction/airdrop_sender_factories_with_the_Factory_suffix
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58846ec
to
33dd151
Compare
This was referenced Feb 17, 2024
buffalojoec
reviewed
Feb 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I quite like this! I'll defer to @lorisleiva on any specifics from the discussions, but lgtm.
As long as we're sure that any VS Code hovering activity will never expose _INTERNAL_DO_NOT_EXPORT
...
lorisleiva
approved these changes
Feb 19, 2024
33dd151
to
ee2cd06
Compare
This was referenced Feb 20, 2024
Merge activity
|
🎉 This PR is included in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to make it abundantly clear what kind of transaction sender you're creating by renaming these to
{METHOD}Factory
. This will make them come up first in autocomplete when someone types, for instance,sendAndConfirm
.Closes #2120.