Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Rename all transaction/airdrop sender factories with the ‘Factory’ suffix #2130

Conversation

steveluscher
Copy link
Contributor

@steveluscher steveluscher commented Feb 16, 2024

Summary

The goal of this PR is to make it abundantly clear what kind of transaction sender you're creating by renaming these to {METHOD}Factory. This will make them come up first in autocomplete when someone types, for instance, sendAndConfirm.

Closes #2120.

@steveluscher steveluscher force-pushed the 02-16-Rename_all_transaction/airdrop_sender_factories_with_the_Factory_suffix branch from 58846ec to 33dd151 Compare February 17, 2024 00:37
@steveluscher steveluscher marked this pull request as ready for review February 17, 2024 00:58
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I quite like this! I'll defer to @lorisleiva on any specifics from the discussions, but lgtm.

As long as we're sure that any VS Code hovering activity will never expose _INTERNAL_DO_NOT_EXPORT...

@steveluscher steveluscher force-pushed the 02-16-Rename_all_transaction/airdrop_sender_factories_with_the_Factory_suffix branch from 33dd151 to ee2cd06 Compare February 20, 2024 22:26
@steveluscher
Copy link
Contributor Author

steveluscher commented Feb 20, 2024

Merge activity

@steveluscher steveluscher merged commit 2d1d49c into master Feb 20, 2024
8 of 10 checks passed
@steveluscher steveluscher deleted the 02-16-Rename_all_transaction/airdrop_sender_factories_with_the_Factory_suffix branch February 20, 2024 22:57
Copy link
Contributor

github-actions bot commented Mar 2, 2024

🎉 This PR is included in version 1.90.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[experimental] Rename all factory methods as such
3 participants