Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA-3 support #339

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Add SHA-3 support #339

wants to merge 9 commits into from

Conversation

fxdupont
Copy link
Contributor

@fxdupont fxdupont commented Sep 4, 2017

Please hold:

  • OpenSSL has a bug in HMAC code (HMAC_MAX_MD_CBLOCK publicly defined with a too small value), cf issue #4335
  • Botan has (had!) a bug impacting RSA PKCSv1.5 with SHA-3 (note the DNSSEC IETF draft uses RSA PSS following a comment I sent to authors)
    So there are a few things to finish (i.e. I pull this mainly to show what could be done).
    SHA-3 is supported for hash, hmac (but see OpenSSL note), rsa pkcs (but see Botan note) and rsa pss (should be checked for DNSSEC soon).

@halderen halderen added the hold On hold label Feb 27, 2020
@pawal
Copy link

pawal commented Feb 11, 2021

Does Botan and OpenSSL still has these problems?

@vladislav-kovtun
Copy link

HMAC_MAX_MD_CBLOCK has been deprecated by OpenSSL. Documentation by OpenSSL suggests that it should be replaced with EVP_MAX_MD_SIZE instead.

@jschlyter
Copy link
Contributor

Please rebase on develop and mark as ready when ready.

@jschlyter jschlyter marked this pull request as draft November 29, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold On hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants