SNOW-74190: fixed comments query

snowflakedb · Apr 9, 2019 · 3741cd0 · 3741cd0
1 parent d873f00
commit 3741cd0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/snowdialect.py b/snowdialect.py
@@ -392,7 +392,8 @@ def _get_columns_for_tables(self, connection, schema, **kw):
        ic.numeric_scale,
        ic.is_nullable,
        ic.column_default,
-       ic.is_identity
+       ic.is_identity,
+       ic.comment
   FROM information_schema.columns ic
  WHERE ic.table_schema=%(table_schema)s
 """

diff --git a/test/test_core.py b/test/test_core.py
@@ -969,7 +969,7 @@ def test_copy_into_location(engine_testaccount, sql_compiler):
         food_items.drop(engine_testaccount)
 
 def test_comments(engine_testaccount):
-    table_name = ''.join(random.choice(string.ascii_uppercase + string.digits) for _ in range(5))
+    table_name = ''.join(random.choice(string.ascii_uppercase) for _ in range(5))
     try:
         engine_testaccount.execute("create table public.{} (\"col1\" text);".format(table_name))
         engine_testaccount.execute("alter table public.{} alter \"col1\" comment 'this is my comment'".format(table_name))