Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo update on the runtime lockfiles and the SDK lockfile #3989

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

aws-sdk-rust-ci
Copy link
Collaborator

If CI fails, commit the necessary fixes to this PR until all checks pass.

If changes are required to crateNameToLastKnownWorkingVersions, revert the first commit in the PR, run ./gradlew aws:sdk:cargoUpdateAllLockfiles, and commit the updated lockfiles.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@landonxjames landonxjames requested a review from a team as a code owner January 30, 2025 05:34
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@ysaito1001
Copy link
Contributor

ysaito1001 commented Jan 30, 2025

Adding wit-bindgen-rt to false positives list looks good, but I believe we need to keep

[[package]]
name = "wit-bindgen-rt"
version = "0.33.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3268f3d866458b787f390cf61f4bbb563b922d091359f9608842999eaee3943c"
dependencies = [
 "bitflags 2.8.0",
]

in aws/rust-runtime/Cargo.lock (in other words, commit 4f2fb25 should've kept that entry) because that's what this error is complaining about.

My bad, this entry can be removed so we should revert commit f480d49. Instead, we need to pass Some(&FALSE_POSITIVES) to audit_runtime_lockfile_covered_by_sdk_lockfile even when checking aws runtime lockfile. In other words, we can probably collapse this if statement now that both branches will do the same thing.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could also revert f480d49 and remove comments, that'd be great. Otherwise looks good.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

From aws-inlineable to aws-http. Both contribute to introducing the
wit-bindgen-rt dependency, but aws-inlineable is not present in the
AWS_SDK_RUNTIMES in the audit tool (since it isn't a published crate)
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@landonxjames landonxjames added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 5e965d9 Jan 31, 2025
42 of 44 checks passed
@landonxjames landonxjames deleted the update-all-lockfiles-1738101759 branch January 31, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants