Fix password reset and batch sign pin problems #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celuchmarek
commented
Dec 1, 2023
jsuchal
reviewed
Dec 1, 2023
| throw e; | ||
| } | ||
| } catch (Exception e) { | ||
| AutogramException autogramException = new AutogramException("Document signing has failed", "", "", e); |
There was a problem hiding this comment.
Nechceme tu hodit unrecognizedexception?
There was a problem hiding this comment.
No, toto je naviazané na tú logiku Batch Signingu, že tie errory sa niekam zapisujú a na konci ich uvidíš všetky, ak to nie je error, ktorý ukončuje batch. Už sme sa bavili, že celý ten batch signing treba zrefaktorovať, ale radšej by som to teraz nechytal, keď to funguje.
jsuchal
reviewed
Dec 1, 2023
| ui.onUIThreadDo(() -> { | ||
| ui.cancelBatch(batch); | ||
| signCommon(job, batch.getSigningKey(), (jobNew) -> { | ||
| Logging.log("GUI: Signing batch job: " + job.hashCode() + " file " + job.getDocument().getName()); |
There was a problem hiding this comment.
Neviem, čo tým myslíš. Ja som to len celé zobral z GUI, kde bol pôvodne tento batchSign. Myslíš tým, že to nemusí byť iba file, ale napr. aj nejaký formulár z API a podobne? Neriešil by som to.
jsuchal
reviewed
Dec 1, 2023
src/main/java/digital/slovensko/autogram/core/errors/PINIncorrectException.java
Show resolved
Hide resolved
jsuchal
reviewed
Dec 1, 2023
jsuchal
reviewed
Dec 1, 2023
jsuchal
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.