AG-103 Časové pečiatky #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
requested changes
Nov 24, 2023
|
|
||
| public Autogram(UI ui, boolean shouldDisplayVisualizationError , DriverDetector driverDetector) { | ||
| this(ui, shouldDisplayVisualizationError, driverDetector, -1); | ||
| public Autogram(UI ui, boolean shouldDisplayVisualizationError , DriverDetector driverDetector, TSPSource tspSource) { |
There was a problem hiding this comment.
Tu sa nam to zacina kopit a imho by vlastne mal do Autogramu vliezt nejaky settings. To by potom riesilo aj problem, ze potrebujeme restart.
| } | ||
|
|
||
| public static SigningJob buildFromFileBatch(File file, Autogram autogram, Responder responder, boolean checkPDFACompliance, SignatureLevel signatureType, boolean isEn319132) { | ||
| public static SigningJob buildFromFile(File file, Responder responder, boolean checkPDFACompliance, SignatureLevel signatureType, boolean isEn319132, TSPSource tspSource) { |
There was a problem hiding this comment.
Aj tu by voslo settings a tspsource + isEn319132 si nastavis podla settings (aktualnych)
Comment on lines
+201
to
+205
| return SigningParameters.buildForPDF(document, checkPDFACompliance, isEn319132, tspSource); | ||
| case XAdES_BASELINE_B: | ||
| return SigningParameters.buildForASiCWithXAdES(filename, document, isEn319132); | ||
| return SigningParameters.buildForASiCWithXAdES(document, isEn319132, tspSource); | ||
| case CAdES_BASELINE_B: | ||
| return SigningParameters.buildForASiCWithCAdES(filename, document, isEn319132); | ||
| return SigningParameters.buildForASiCWithCAdES(document, isEn319132, tspSource); |
There was a problem hiding this comment.
Ak by sme tu tieto veci vytahovali zo settings, tak nemusime restart?
src/main/java/digital/slovensko/autogram/ui/gui/MainMenuController.java
Outdated
Show resolved
Hide resolved
Comment on lines
+27
to
+28
| addOption(null, "en319132", false, "Sign according to EN 319 132 or EN 319 122."). | ||
| addOption(null, "tsa-server", true, "Url of TimeStamp Authority server that should be used for timestamping in signature level BASELINE_T. If provided, BASELINE_T signatures are made."); |
There was a problem hiding this comment.
Pre GUI nevidim asi settings ci zle pozeram?
jsuchal
reviewed
Nov 24, 2023
src/main/resources/digital/slovensko/autogram/ui/gui/settings-dialog.fxml
Outdated
Show resolved
Hide resolved
jsuchal
reviewed
Nov 24, 2023
src/main/java/digital/slovensko/autogram/ui/gui/SettingsDialogController.java
Outdated
Show resolved
Hide resolved
jsuchal
reviewed
Nov 24, 2023
src/main/java/digital/slovensko/autogram/ui/gui/SettingsDialogController.java
Show resolved
Hide resolved
…dialog.fxml Co-authored-by: Jano Suchal <jans@solver.sk>
jsuchal
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.