Janitor: Update the image crate #4816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Mar 11, 2024
|
Looks like the link is failling on Windows with missing symbols relative to the image crate :-( |
|
And in a way strange way. There are unresolved symbols relating to image loading, but also these: |
ogoffart
force-pushed
the
olivier/dependencies-updates
branch
from
1098a89 to
66b3ec0
Compare
Note: this could be a breaking change if someone did
```
image = { version = "0.24", features = [...] }
```
To enable more features decoder of the image to support more file format
in slint
ogoffart
force-pushed
the
olivier/dependencies-updates
branch
from
31dffc4 to
a88bc23
Compare
To enable the feature from the image crate. And enable it by default. Because users of older version of slint may have enabled feature from the image 0.24 crate. But since we upgrade to image 0.25, this these format would not be supported by Slint. So enable them by default to keep compatibility
|
Added a commit to add a (enabled by default) feature to enable all image backends with the image 0.25 crate, in order not to break the backends that were enabled for the 0.24 by users |
tronical
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this could be a breaking change if someone did
to enable more features decoder of the image to support more file format in slint