Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support random noise by import js_sys::Math::random function #162

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

benliao
Copy link
Contributor

@benliao benliao commented Dec 18, 2023

No description provided.

@silvia-odwyer
Copy link
Owner

@benliao Thanks very much for your contribution, it's greatly appreciated! 😄 It's great to have WASM support for the noise filters. I'm just wondering if you could run cargo fmt on the directory so that the formatting test will pass. I will then merge your contribution ✅

@benliao
Copy link
Contributor Author

benliao commented Dec 18, 2023

@silvia-odwyer, sorry for missing run "cargo fmt" the new commit has run cargo fmt and no modification to cargo.toml, with contributor information in the readme. thanks.

@benliao
Copy link
Contributor Author

benliao commented Dec 19, 2023

@silvia-odwyer The noise function has been added to the webpack demo, the cargo test passed, and the cargo formatted. The add_noise_rand function parameter and return changed to work with the webpack demo and aligned with other interfaces.

@benliao
Copy link
Contributor Author

benliao commented Dec 19, 2023

@silvia-odwyer, Sorry to bother you; just fixed the Clippy check fail.

@silvia-odwyer
Copy link
Owner

@benliao Thanks very much for your excellent contribution again, and for updating the online demo also 😄 Going to merge this now ✅

@silvia-odwyer silvia-odwyer merged commit d53cb48 into silvia-odwyer:master Dec 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants