feat: add configuration files for project setup with Poetry and pre-c… #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silver6wings
reviewed
Apr 4, 2025
| @@ -0,0 +1,35 @@ | |||
| [[tool.poetry.source]] | |||
There was a problem hiding this comment.
这个poertry和pip是否冲突，我的目的是不想因为引用新技术而抬高用户的使用门槛，如果这个跟pip本身不冲突那没关系（当然也担心这些奇怪文件吓跑新手）
There was a problem hiding this comment.
pip 可以继续使用，二者不冲突。
用 poetry 只是方便装了 isort 等，其实也可以不用 poetry
| - repo: local | ||
| hooks: | ||
| - id: system | ||
| name: isort |
There was a problem hiding this comment.
这个isort是需要把tushare那个库给ignore掉，因为默认导入tushare会有默认logging格式冲突的问题（reader那个目录）
| - repo: local | ||
| hooks: | ||
| - id: system | ||
| name: ruff |
| - repo: local | ||
| hooks: | ||
| - id: system | ||
| name: pylint |
There was a problem hiding this comment.
pylint这个会强制开发者执行么？毕竟fork的人比较多，让他们提交不了估计要炸毛
There was a problem hiding this comment.
只有执行过 pre-commit install 的用户在 commit 后才会进行 pre-commit-config 中的检查，否则不会检查
| - repo: local | ||
| hooks: | ||
| - id: system | ||
| name: mypy |
There was a problem hiding this comment.
那个xtquant文件夹是复制进来的第三方库，需要ignore掉
| package-mode = false | ||
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.12" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ommit hooks