-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fetching signatures without remote get. #4047
Enable fetching signatures without remote get. #4047
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
+ Coverage 30.33% 36.51% +6.18%
==========================================
Files 151 209 +58
Lines 9439 13357 +3918
==========================================
+ Hits 2863 4877 +2014
- Misses 6134 7859 +1725
- Partials 442 621 +179 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Haus <dhaus@redhat.com> Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
aa1a890
to
4580e7b
Compare
@dmitris Could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The change seems to be consistent with what the attestation code is doing; there seems to be no change in behavior other than a minor formatting of the error output, but that shouldn't be an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cosign](https://github.com/sigstore/cosign) | patch | `2.4.2` -> `2.4.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sigstore/cosign (cosign)</summary> ### [`v2.4.3`](https://github.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v243) [Compare Source](sigstore/cosign@v2.4.2...v2.4.3) #### Features - Bump sigstore/sigstore to support KMS plugins ([#​4073](sigstore/cosign#4073)) - Enable fetching signatures without remote get. ([#​4047](sigstore/cosign#4047)) - Feat/file flag completion improvements ([#​4028](sigstore/cosign#4028)) - Update builder to use go1.23.6 ([#​4052](sigstore/cosign#4052)) #### Bug Fixes - fix parsing error in --only for cosign copy ([#​4049](sigstore/cosign#4049)) #### Cleanup - Refactor verifyNewBundle into library function ([#​4013](sigstore/cosign#4013)) - fix comment typo and imports order ([#​4061](sigstore/cosign#4061)) - sync comment with parameter name in function signature ([#​4063](sigstore/cosign#4063)) - sort properly Go imports ([#​4071](sigstore/cosign#4071)) #### Contributors - Bob Callaway - Carlos Tadeu Panato Junior - Cody Soyland - Dmitry Savintsev - Hayden B - Tomasz Janiszewski - Ville Skyttä </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODAuMiIsInVwZGF0ZWRJblZlciI6IjM5LjE4MC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Summary
When using cosign as a dependency and attempting to fetch signatures for a specific signed entity, the signed entity is always fetched from the registry.
In case the signed entity has been fetched previously, it'd be nice to introduce a function similar to the
FetchAttestations
that allows to fetch signatures from the signed entity directly, without reaching out to the registry to fetch the signed entity beforehand.With the current changes in the PR, the error will now not include the reference anymore. However, the changes were also made to
FetchAttestations
in the same way.If we want to include this information, we may wrap the returned error from
FetchAttestations
/FetchSignatures
with the reference, so the content of the error will stay the same.Release Note
NONE
Refs: