Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Card component to use the Docusaurus Link component #107

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

niravcodes
Copy link
Contributor

@niravcodes niravcodes commented Mar 3, 2025

Other Changes Pull Request

Description

The Card component was treating all links as simple anchor <a> links, thus not leveraging the React Router's fast SPA-like routing, and always falling back to the slower browser routing.

This PR fixes that.

Related Issue

Link to the issue here: [Issue #](

Type of Change

  • Docusaurus update/maintenance
    • Dependency update
    • Configuration change
    • Plugin update
    • Bug fix
    • Style Change
  • Performance improvement
  • Refactoring
  • Build process update
  • Other (please specify):

Docusaurus Update/Maintenance Details

  • Dependency Update: Name and version of the updated dependency
  • Configuration Changed: Describe the configuration changes made
  • Plugin Update: Name and version of the updated plugin
  • Bug Fix: Describe the bug that was fixed and the solution
  • Style Change: Describe the style changes implemented

Other Change Details (if applicable)

  • Description: Provide a detailed description of the change

Motivation and Context

Less jarring and more SPA-like transitions where possible when clicking Cards that are linked to internal docs.

Checklist:

  • My changes follow the style guidelines of this project
  • I have performed a self-review of my changes
  • My changes generate no new warnings
  • Builds successfully locally

Additional Notes

Add any other context about the pull request here.

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for signalwire-docs ready!

Name Link
🔨 Latest commit 98a6a7f
🔍 Latest deploy log https://app.netlify.com/sites/signalwire-docs/deploys/67c6019e4700ea0008b67b31
😎 Deploy Preview https://deploy-preview-107--signalwire-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Devon-White
Devon-White previously approved these changes Mar 3, 2025
@niravcodes niravcodes changed the title Fix the Card component to use the Docusaurus Link component WIP Fix the Card component to use the Docusaurus Link component Mar 3, 2025
@niravcodes niravcodes changed the title WIP Fix the Card component to use the Docusaurus Link component Fix the Card component to use the Docusaurus Link component Mar 3, 2025
@Devon-White Devon-White merged commit 7f6355b into main Mar 3, 2025
4 checks passed
@Devon-White Devon-White deleted the nko/cardfix branch March 3, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/general General Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants