Skip to content

Commit

Permalink
Move @typings/jest to devDependencies
Browse files Browse the repository at this point in the history
Since jest functions are global, their typing tends to conflict with other global properties in
global space. This commit moves jest typings to devDependencies, where they won't be
included for projects that require jest-fetch-mock.

This is very similar to a protractor issue, reference here-
angular/protractor#3792
angular/protractor#3795
  • Loading branch information
simon-taft-wd committed Aug 27, 2018
1 parent b95badd commit fa35aa5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@
},
"homepage": "https://github.com/jefflau/jest-fetch-mock#readme",
"dependencies": {
"@types/jest": "^23.0.0",
"isomorphic-fetch": "^2.2.1",
"promise-polyfill": "^7.1.1"
},
"devDependencies": {
"@types/jest": "^23.0.0"
},
"prettier": {
"semi": false,
"editor.formatOnSave": true,
Expand Down

0 comments on commit fa35aa5

Please sign in to comment.