Propose new default filter_by for name #41
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just tested this so that I can allow dashes and underscores in filenames but disallow the others. Effectively an alphanumeric with the two character exceptions.
|
Hey! Great suggestion! The reason we haven't added understcore by default is because some of the tokens in the templates are separated by underscore (eg. |
|
Leaving this PR open as Manne's comment above is very insightful for anyone thinking about making this change, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose this modification to make the default filter allow the dash and underscore characters but disallow the other special characters.
Not sure how this affects unicode and other language support.