fix: PHPStan changes

shopware · Feb 11, 2025 · 2b95793 · 2b95793
1 parent 0f9eff5
commit 2b95793
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/src/Installment/Banner/InstallmentBannerSubscriber.php b/src/Installment/Banner/InstallmentBannerSubscriber.php
@@ -185,7 +185,7 @@ private function getCountryCode(SalesChannelContext $salesChannelContext): strin
             return $isoCode;
         }
 
-        return $salesChannelContext->getShippingLocation()->getCountry()->getIso();
+        return $salesChannelContext->getShippingLocation()->getCountry()->getIso() ?? '';
     }
 
     private function pageOfCorrectType(Page $page): bool

diff --git a/src/Util/PayLaterAvailabilityChecker.php b/src/Util/PayLaterAvailabilityChecker.php
@@ -16,7 +16,7 @@
 class PayLaterAvailabilityChecker
 {
     /**
-     * @var array<string, array<string, float>>
+     * @var array<string, array<string, string|float>>
      *
      * @see https://developer.paypal.com/studio/checkout/pay-later/{{countryCode}}
      */

diff --git a/tests/Util/Availability/AvailabilityContextBuilderTest.php b/tests/Util/Availability/AvailabilityContextBuilderTest.php
@@ -5,7 +5,7 @@
  * file that was distributed with this source code.
  */
 
-namespace Swag\PayPal\Test\Util\Lifecycle;
+namespace Swag\PayPal\Test\Util\Availability;
 
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;

diff --git a/tests/Util/Availability/AvailabilityServiceTest.php b/tests/Util/Availability/AvailabilityServiceTest.php
@@ -5,7 +5,7 @@
  * file that was distributed with this source code.
  */
 
-namespace Swag\PayPal\Test\Util\Lifecycle;
+namespace Swag\PayPal\Test\Util\Availability;
 
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;

diff --git a/tests/Util/Lifecycle/Method/PayLaterMethodDataTest.php b/tests/Util/Lifecycle/Method/PayLaterMethodDataTest.php
@@ -8,6 +8,7 @@
 namespace Swag\PayPal\Test\Util\Lifecycle\Method;
 
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Shopware\Core\Framework\Log\Package;
 use Swag\PayPal\Checkout\Payment\Method\PayLaterHandler;
@@ -64,9 +65,7 @@ public function testGetTechnicalName(): void
         static::assertSame('swag_paypal_pay_later', $this->payLaterMethodData->getTechnicalName());
     }
 
-    /**
-     * @dataProvider availabilityProvider
-     */
+    #[DataProvider('availabilityProvider')]
     public function testIsAvailable(string $currencyCode, string $countryCode, float $totalAmount, bool $expected): void
     {
         $availabilityContext = $this->createMock(AvailabilityContext::class);