Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run integration tests with the corresponding runtime #244

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 9, 2025

#242 introduced support for Deno and Bun, and updated the integration tests pipeline to run against them.

However, the commands being run are making it execute on node.js in all cases, even if those runtimes are installed.

This PR ensures the tests are in fact run with the proper runtime.

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.55%. Comparing base (0d61540) to head (ebec6aa).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files           8        8           
  Lines         309      309           
  Branches       95       95           
=======================================
  Hits          218      218           
  Misses          3        3           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya force-pushed the feature/int-tests-runtimes branch 4 times, most recently from bbb4385 to eec53f3 Compare February 9, 2025 12:12
@acelaya acelaya force-pushed the feature/int-tests-runtimes branch from eec53f3 to ebec6aa Compare February 9, 2025 12:16
@acelaya acelaya marked this pull request as ready for review February 10, 2025 16:53
@acelaya acelaya merged commit 674106d into shlinkio:main Feb 10, 2025
40 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant