feat: allow nested decorations which share an 'edge' with parent #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jan 28, 2025
antfu
changed the title
antfu
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for nested decorations which share a start or end. You can currently share a start and end, or share neither.
If start is shared, e.g.
[{ start: 6, end: 10 }, { start: 6, end; 9 }], then you receive an end index error:-ShikiError: Failed to find end index for decoration {"line":0,"character":9,"offset":9}
If end is shared, e.g.
[{ start: 6, end: 10 }, { start: 7, end; 10 }], then you receive an intersection error:-ShikiError: Decorations {"line":0,"character":6,"offset":6} and {"line":0,"character":7,"offset":7} intersect.
Linked Issues
#910
Additional context