-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve fee explainer informations #8896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With monkey:

Without monkey:

Nitpick @NeOMakinG if we want to tackle this here too: in swapper overview component, we should round (up for consistency) to 2dp as well, so we don't end up with a) a discrepancy and b) a weird .123 kind of amount, which isn't really a valid fiat amount the way one would think about it

5d58e68
to
d39f26b
Compare
Rounded up in d39f26b |
Description
$0.00
which was not sexyTo be done in a follow up:
Issue (if applicable)
closes #8813
Risk
Low (presentational)
Testing
Engineering
Operations
Screenshots (if applicable)
Very close date
1 week ago