-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: savers read-only opportunities #8878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great functional pass @0xApotheosis! 4 birds, one stone https://jam.dev/c/ec57988d-6cd1-4f78-93ea-5cf32b20e4b9 :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One potential edge-case bug, but happy to get this in in the name of progress.
Description
Makes THORChain savers opportunity view-only and balance-only: can only see them if you have a balance, and can't interact with them through the app's modal but instead are linked to THORChain's X for keeping up-to-date with updates.
Issue (if applicable)
closes #8866
Risk
Low, risk of borked opportunities, though should be pretty easy to test given we've removed the "By Provider" view
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/3bda7b99-8dbe-4e2d-a3e6-dd70d9e7aa71
https://jam.dev/c/fab5c32b-fa34-4b74-af29-d76eabe8a614