-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mergefix origin/release #8362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
commented
Dec 13, 2024
packages/swapper/src/swappers/LifiSwapper/getTradeQuote/getTradeQuote.ts
Show resolved
Hide resolved
gomesalexandre
commented
Dec 13, 2024
packages/swapper/src/swappers/LifiSwapper/getTradeQuote/getTradeQuote.ts
Show resolved
Hide resolved
gomesalexandre
commented
Dec 13, 2024
packages/swapper/src/swappers/LifiSwapper/getTradeQuote/getTradeQuote.ts
Show resolved
Hide resolved
gomesalexandre
commented
Dec 13, 2024
gomesalexandre
commented
Dec 13, 2024
packages/swapper/src/swappers/ArbitrumBridgeSwapper/getTradeRate/getTradeRate.ts
Show resolved
Hide resolved
NeOMakinG
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://jam.dev/c/cc964c86-984c-4b34-a820-78c671b2dc0a
Get this in so we can handle the release
Li.Fi bridges are taking a long time or failing at fetching the TX status, not related to those changes thought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks and mergefixes changes introduced by #8348 (present in [release](#8337 only, but not develop) on top of #8350 and #8309 (present in develop only), so we can run the release script.
This also fixes one regression in 895e0c0, introduced by #8309 i.e present in develop but not in release re: failing approvals for some swappers
Issue (if applicable)
closes N/A
Risk
Low to none, ensure mergefix looks sane
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/4603d1a2-b00d-4a58-810c-7c5d2c18595b
https://jam.dev/c/911d5019-e0d3-433c-ab7f-91c75b52fc73
https://jam.dev/c/f29c2929-b05e-4033-a096-f970e4ebbd32
https://jam.dev/c/cab5446a-c9e1-4fd6-a526-977e74095e5a
https://jam.dev/c/63f6bbea-3846-4f0c-acc1-a484c9faa4c4
https://jam.dev/c/3e5780d5-e0ef-4cde-bbab-ece8d4285134
https://jam.dev/c/8c82a6bf-59e0-43d6-aa24-1833bc3497bb