Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: graceful evm accounts derivation failure tolerance #7549

Merged
merged 3 commits into from
Aug 13, 2024
Merged

fix: graceful evm accounts derivation failure tolerance #7549

merged 3 commits into from
Aug 13, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Aug 13, 2024 •
edited
Loading

Description

This PR fixes account derivation for EVM chains when one of the daemon URLs fail - fixing a regression introduced in #7497

Repro Steps

  • In develop/prod, either locally or upstream, block any of the EVM daemon URLs
  • Clear your cache fully (i.e no native wallet remaining)
  • Import a native wallet
  • Notice no EVM acount is present

Testing

  • Do the repro steps above, and
    • ensure EVM accounts are present (except for the one/many blocked URLs)
    • ensure smart contract checks are still happy (note: if you've blocked a daemon URL for the chain your sc is on, you'll see no account, which is correct, as unchained's /api/v1/account/<account> calls will be borked)

Screenshots

develop/prod

Screenshot 2024-08-13 at 11 56 13

This diff

  • smart contract checks are still happy - blocked unchained RPC url for the chain the sc is on
image image image image image
  • smart contract checks are still happy - happy unchained
image image
  • Native is still happy with Avalanche and Gnosis unchained XHRs blocked

https://jam.dev/c/75ce3e71-a54f-407e-91e2-63395d4ef0f7

  • Native is still happy with no XHRs blocked

https://jam.dev/c/d011323e-6f9a-4400-8f18-9bda98326cfd

@gomesalexandre gomesalexandre changed the title chore: hotfix release v1.658.0 fix: hotfix graceful evm accounts derivation failure tolerance Aug 13, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review August 13, 2024 19:27
@gomesalexandre gomesalexandre requested a review from a team as a code owner August 13, 2024 19:27
kaladinlight
kaladinlight approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@kaladinlight kaladinlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@gomesalexandre gomesalexandre changed the base branch from main to develop August 13, 2024 21:10
@gomesalexandre gomesalexandre enabled auto-merge (squash) August 13, 2024 21:13
@gomesalexandre gomesalexandre changed the title fix: hotfix graceful evm accounts derivation failure tolerance fix: graceful evm accounts derivation failure tolerance Aug 13, 2024
@gomesalexandre gomesalexandre merged commit ec72fac into develop Aug 13, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the hotfix_evm_accounts_derivation branch August 13, 2024 21:18
@gomesalexandre gomesalexandre mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @kaladinlight