chore: release v1.657.0 #7538
Merged
chore: release v1.657.0 #7538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: invalidate outdated translations * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * chore: en copy and translation fixes --------- Co-authored-by: Hellhound13 <hellhound13@gmx.at> Co-authored-by: Jpanam <jorgepana26@hotmail.com> Co-authored-by: shunshun-lab <shun.taka.726@gmail.com> Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com> Co-authored-by: Markus Meyer <djarmy@gmail.com> Co-authored-by: Romko <29romko29@gmail.com> Co-authored-by: tonyjiang12399 <327904087@qq.com>
* chore: move ledger app check into a hook * chore: exhaustiveness in chain switch * chore: break out body of LedgerOpenApp into a separate component * wip: prompt user to open leger app when clicking approval * feat: use a modal to handle ledger app opening when verifying addresses * feat: wire up ledger app open logic to approvals and trades * chore: move ledger app hook into hooks directory * chore: cleanup * feat: use ledger open app modeal for account management drawer * chore: cleanup * chore: naming * fix: inability to connect chains * chore: comments * fix: make copy generic * chore: rename const * fix: review feedbacks * fix: review feedbacks --------- Co-authored-by: NeOMakinG <14963751+NeOMakinG@users.noreply.github.com> Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>
0xApotheosis
commented
Aug 12, 2024
There was a problem hiding this comment.
Smoke test with clean cache:
✅ Happy path swap
https://snowtrace.dev/tx/0x023f8f9612f7445d4169229d13dd7726313c66ecb68ce7094bacf07b25ebfb34
❓ Zerion spew
Not a bug, but we should clean this up
✅ rFOX dashboard values loading
✅ Lending - positions loading
✅ Pools - positions loading
✅ Earn
✅ On-ramp loading, but some invalid address spew we might want to address
✅ Wallet loading with assets, positions, and TX history
✅ Asset page with charts, market data and related assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: global ledger app gate (#7386)
chore: remove zerion csp (#7527)
fix: runepool about copy (#7532)
fix: runepool checkbox visibility using light mode (#7536)
feat: defi confirmed status improve copy (#7533)
fix: runepool as eligible opportunity (#7534)
feat: implement findPriceHistoryByAssetId (#7503)
feat: regenerate asset data 08/08/2024 (#7516)
fix: asset page infinit loading icon (#7492)
fix: narrow smart contract wallets accounts (#7497)
chore: update app translations (#7517)
chore: adds feature flag and some copy updates to PR template (#7524)