fix: dangerous small amount warning #6044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug introduced in https://github.com/shapeshift/web/pull/5971/files#diff-b6f4d6672824399e71740531e3b09efe3ad3fabeb3ad6c4ce0763969f9d39ab7R104, where we try and select
selectSellAmountCryptoBaseUnit(state)
, which yieldsundefined
becausefirstHop
is undefined at that time:Fixed by
local
quote and running the same selector logic against it, instead of introspecting the not-yet-defined hop state!sellAmountCryptoBaseUnit
which should not happen anymore, but in case it does, we are safu.Pull Request Type
Issue (if applicable)
closes #6037
Risk
This isn't high risk - while it does touch quote validation, it is moderate to low risk as we had all the logic baked in already for a long time and stable, but were reacting on the wrong value since #5971 refactor
High Risk PRs Require 2 approvalsTesting
Engineering
☝🏽
Operations
Screenshots (if applicable)