feat: thorchain utxo tx parsing #5986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaladinlight
force-pushed
the
thorchain-utxo-tx-parsing
branch
from
37a85d7 to
cdf5fde
Compare
There was a problem hiding this comment.
Retested locally after fixing translations - overall LGTM, minus one issue with LP withdraw inbound
UTXO LP Deposit
UTXO LP Withdraw
- Inbound is sad @kaladinlight 😢
https://viewblock.io/thorchain/tx/41D01C2860C8E6B3E4437F8EBE4EFE625DA4B9CB88CB5F519E9F849BEDC63FE1
- Outbound is happy
https://blockchair.com/bitcoin-cash/transaction/eb6fe3ff3846efbd530a7834812bb62ce63fb13c29d2a29709d84ead9bd6c460
Savers Deposit inbound
Savers withdraw outbound
Savers withdraw inbound
- isn't properly detected, though as I can see this isn't a bug but a feature, this isn't implemented and we probably don't have enough data from the Tx to make this work?
Loan Open
Loan Close
Wasn't able to test as my deposit amount is too low
kaladinlight
force-pushed
the
thorchain-utxo-tx-parsing
branch
from
21ac43a to
f58e07a
Compare
|
@gomesalexandre can you give me the tx for savers withdraw inbound so I can look at it? |
|
swap back |
Ok, looks like this is a memo-less withdrawal. We can add logic to handle this, but it will be a bit more complicated. I will add a follow up ticket to address. We can add the memo to our withdrawal transactions in the meantime so we can detect display as is for savers withdrawals moving forward as well. Marginal increase in tx fee |
gomesalexandre
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add transaction parsing for all supported thorchain transactions and associated transaction rows
Pull Request Type
Issue (if applicable)
#5967
Risk
Lowish - this is all additive, but we want to make sure the transactions are being displayed accurately
Testing
Ensure the transaction row is displaying the correct type and information for the following thorchain types on utxo chains:
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
Swaps
Streaming Swaps
Savers
LP
Loan
