Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thorchain: handle memo-less savers action parsing #6001

Closed
kaladinlight opened this issue Jan 15, 2024 · 1 comment
Closed

Thorchain: handle memo-less savers action parsing #6001

kaladinlight opened this issue Jan 15, 2024 · 1 comment
Assignees

Comments

@kaladinlight
Copy link
Contributor

Overview

Thorchain tx parsing was recently added for utxos, but it was discovered that we aren't handling parsing of memo-less savers transactions (deposit and withdraw). To make things lighter on the back end, we can add memos to our savers transactions for easier detection, however, we would still ideally like to parse memo-less transactions, so we should still add logic to handle this.

References and additional details

https://dev.thorchain.org/thorchain-dev/saving-guide/quickstart-guide

Acceptance Criteria

  • query midgard for transactions that don't have op_return/input data (can we be smarter about this to not over query midgard on every transaction?)
  • parse midgard response to return savers action

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@kaladinlight kaladinlight self-assigned this Feb 6, 2024
@twblack88 twblack88 moved this from To schedule to Blocked in ShapeShift Dashboard Mar 12, 2024
@kaladinlight
Copy link
Contributor Author

going to close since we have memos now and not mission critical

@github-project-automation github-project-automation bot moved this from Blocked to Done in ShapeShift Dashboard Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant