Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Idle from investor / market-service #5770

Closed
gomesalexandre opened this issue Dec 4, 2023 · 0 comments · Fixed by #6060
Closed

Remove Idle from investor / market-service #5770

gomesalexandre opened this issue Dec 4, 2023 · 0 comments · Fixed by #6060
Assignees

Comments

@gomesalexandre
Copy link
Contributor

gomesalexandre commented Dec 4, 2023

Overview

The follow-up of #5729.
#5729 removes Idle as a feature, i.e all the web bits, but investor-idle is still required, because of the needs for market-data.

This is needed because current Idle assets would just have wrong/no market-data, hence market-service (and investor) were left over.

This issue ensures we remove Idle from investor as well as market-service.

References and additional details

Market-service: https://github.com/shapeshift/web/blob/develop/src/lib/market-service/idle/idle.ts
investor-idle: https://github.com/shapeshift/web/tree/develop/src/lib/investor/investor-idle

Acceptance Criteria

  • Idle market-service bits are removed
  • investor-idle is removed
  • there are no remaining Idle references in the codebase

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

2 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant