Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove idle market-service #6060

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 23, 2024

Description

Does what it says on the box πŸ‘‹πŸ½

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5770

Risk

High Risk PRs Require 2 approvals

Low to none - ensure Idle market data still looks sane

Testing

  • Idle market data looks sane against develop

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

  • Develop
Screenshot 2024-01-23 at 14 50 59 Screenshot 2024-01-23 at 14 51 14 Screenshot 2024-01-23 at 14 53 30
  • This diff
Screenshot 2024-01-23 at 14 53 43 Screenshot 2024-01-23 at 14 53 50 Screenshot 2024-01-23 at 14 53 59

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review January 23, 2024 13:57
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 23, 2024 13:57
@gomesalexandre gomesalexandre marked this pull request as draft January 23, 2024 14:43
@gomesalexandre gomesalexandre marked this pull request as ready for review January 23, 2024 17:51
@gomesalexandre gomesalexandre enabled auto-merge (squash) January 23, 2024 19:18
@gomesalexandre gomesalexandre merged commit 3b058c9 into develop Jan 23, 2024
4 checks passed
@gomesalexandre gomesalexandre deleted the feat_rm_idle_market_service branch January 23, 2024 19:24
0xApotheosis pushed a commit that referenced this pull request Jan 24, 2024
This was referenced Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Idle from investor / market-service
2 participants