Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ErrorMessage #41

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Conversation

colas31
Copy link
Contributor

@colas31 colas31 commented Aug 19, 2022

Following this issue #40,
I removed the ErrorMessage when no workspace are open.
I replace it by a welcome message in the three view.
image

Basically it makes no sense to display a message to the user when there is no workspace.
If we follow the VSCode recommendation, the notification message should:

  • Respect the user's attention by only sending notifications when absolutely necessary

Lot of extension are working only when a workspace is open and no error message are displayed, they simply do anything, and are activated only when a workspace is open

@manifestinteractive
Copy link
Member

This is such a great idea. Thanks for the contribution !!! I wanted the user to know they would not see anything and why, but this is a much better solution.

@manifestinteractive manifestinteractive merged commit 7492e39 into sfccdevops:develop Aug 21, 2022
@colas31
Copy link
Contributor Author

colas31 commented Aug 22, 2022

@manifestinteractive ,
I read your changes.
Using the setContext with several viewsWelcome is a really great idea. You can really reflect the state of the extension within a workspace open :)
Nice job

@manifestinteractive
Copy link
Member

@colas31 thanks for the great idea !! I never even thought of using the content within the panel as a method to show the status of the panel when it was not showing the tree view. I am going to borrow that idea for a few other extensions I am working on ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants