Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'explorerExclude.showPicker' configuration option, which when f… #13

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

rw3iss
Copy link
Contributor

@rw3iss rw3iss commented May 22, 2020

…alse will NOT show the file picker, but only hide the currently selected item

What's this PR do?

It adds a check in util.js for a configuration/setting option: "explorerExclude.showPicker".
If this is true (or undefined), the extension works as is... if it is false it will NOT show any file picker/choose after clicking 'Add to hidden items...', but will only hide the already selected item.

Where should the reviewer start?

util.js line 383

How should this be manually tested?

Add a vscode setting called: "explorerExclude.showPicker": false and then try to hide any selected item. Set the value to true and confirm the default behavior works.

Any background context you want to provide?

Sure - I was glad to find an extension that would work within Workspaces, as the 'Make Hidden' extension doesn't. Upon using this, I simply want to hide one item at a time in the explorer (main use case), quickly, without being prompted every time, so I thought making this a configuration option made sense.

Definition of Done:

  • [ x] You have actually run this locally and can verify it works
  • You have verified that npm test passes without issue
  • [ x] You have updated the README file (if appropriate)

…alse will NOT show the file picker, but only hide the currently selected item
@rw3iss
Copy link
Contributor Author

rw3iss commented May 22, 2020

Seems to be an issue with folders not being hideable... I'm not sure if this is by design (from vscode or anywhere), but will omit for now, unless you can amend to allow folders to be hideable.

@manifestinteractive manifestinteractive merged commit b34d03b into sfccdevops:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants