feat: Support Scaleway provider

[cyclimse]

Hello 👋 ,

First of all, thanks for this amazing plugin! It's so great that some peeps have been trying to use it with different Serverless providers.

Currently this plugin has some minor issues when using the "google" or "scaleway" Serverless providers. Here are some of the issues reported previously: #651 and #340

Here are two noticeable issues:

• Loading the python binary from the runtime does not work for providers that uses a python3XX runtime format
• Scaleway expects vendored dependencies to be in a package folder (https://www.scaleway.com/en/docs/compute/functions/how-to/package-function-in-zip#additional-dependencies)

This PR is a quick fix to address those two issues. Thank you!

[pgrzesik]

Hey @cyclimse 👋 Thanks a lot for opening the PR. Unfortunately I'm not familiar with scaleway. Do you think it would be possible to introduce at least one test case that would cover the scaleway provider? Let me know what do you think

[cyclimse]

Hello!

Thanks for the feedback. We're very grateful that you're considering adding this support 🙌

I've added a small test scenario to cover the changes made to the injection path in the zip file. It uses the scaleway-serverless-functions (https://github.com/scaleway/serverless-scaleway-functions) plugin, so I created a new test folder from an existing example.
Let me know if there's anything I can do to help.

Cheers!

[cyclimse]

Hey!

My apologies for the ping but we had some new Scaleway clients that are interested in using this plugin. It would be greatly appreciated if this could be added. Thanks!

[Shillaker]

@pgrzesik any chance of getting this merged or having some feedback on how to improve it? We'd really like to be able to use the project with Scaleway.

Thanks in advance.

[pgrzesik]

Thanks a lot for your work on this one and sorry for not responding sooner. The changes looks reasonable, it would be great to maybe add a small note in the docs that Scaleway is supported. After that I think we're good to merge this one 👍

[cyclimse]

Thank you so so much 💜 (and sorry for the various pings ^^) !!! This will please a lot of people. I've added a small section in the README about Custom Provider Support. Feel free to adjust anything!

Have a lovely week!

[pgrzesik]

Hey @cyclimse 👋 Unfortunatelly it looks like the tests are failing, I see that plugin could not be found. Could you please look into it whenever you have a chance? Thanks! 🙇

[cyclimse]

My apologies, I didn't notice it locally because the serverless-scaleway-functions plugin was installed globally on my machine.

I've updated the test to do an npm i instead of only installing serverless-python-requirements from the npm pack output. I've also run the CI from the fork to make sure it doesn't run into any issues: https://github.com/cyclimse/serverless-python-requirements/actions/runs/5936201608

Cheers!

[pgrzesik]

Hello, really sorry for not responding sooner here, but I was unvailable for a longer period of time. Do you think you could rebase on top of current main? I think we should be good to merge after that 👍

[cyclimse]

No worries, maintaining a popular open-source repo which accept contributions is a ton of work! Thank you so much, I'm so happy we can get this merged ❤️ We often have customers interested in using serverless-python-requirements, so it will be quite nice to provide compatibility.

While rebasing, I had a conflict with #773, I've added a similar safety check via a regex to avoid the issue when translating provider runtimes to the python binary name. They don't quite address the same issue so I think both checks are worth keeping (for instance the #773 check will not be triggered when using the Scaleway provider as the runtimes do indeed start with python) 👍

Cheers!

[pgrzesik]

Thank you sir 🙇 I'm currently resolving some issues that we seem to have on our main branch and then yours should be good to be merged 👍

[pgrzesik]

Hey, I needed to fix some of the minor things on this PR and I did it in a separate PR, once again thanks @cyclimse 🙇