Updated to Selenium 4.18.1

serenity-bdd · Feb 22, 2024 · f5c641a · f5c641a
1 parent 6b83faf
commit f5c641a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -63,8 +63,8 @@
         <commons.net.version>3.10.0</commons.net.version>
         <commons.codec.version>1.16.0</commons.codec.version>
         <freemarker.version>2.3.32</freemarker.version>
-        <selenium.version>4.16.1</selenium.version>
-        <htmlunit.driver.version>4.16.0</htmlunit.driver.version>
+        <selenium.version>4.18.1</selenium.version>
+        <htmlunit.driver.version>4.17.0</htmlunit.driver.version>
         <jsonassert.version>1.5.1</jsonassert.version>
         <jsoup.version>1.15.4</jsoup.version>
         <joda-time.version>2.12.5</joda-time.version>

diff --git a/...y-core/src/test/java/net/thucydides/core/model/WhenRecordingDataDrivenTestOutcomes.groovy b/...y-core/src/test/java/net/thucydides/core/model/WhenRecordingDataDrivenTestOutcomes.groovy
@@ -4,6 +4,7 @@ package net.thucydides.core.model
 import net.thucydides.core.steps.StepEventBus
 import net.thucydides.model.domain.DataTableRow
 import net.thucydides.model.domain.TestOutcome
+import net.thucydides.model.domain.DataTable
 import net.thucydides.model.environment.MockEnvironmentVariables
 import spock.lang.Specification
 

diff --git a/serenity-junit5/src/main/java/net/serenitybdd/junit5/JUnit5TestClassAnnotations.java b/serenity-junit5/src/main/java/net/serenitybdd/junit5/JUnit5TestClassAnnotations.java
@@ -25,9 +25,11 @@ public Optional<String> getDisplayNameGeneration(Method javaMethod) {
 
         Annotation displayNameGenerationAnnotation = testClass.getAnnotation(DisplayNameGeneration.class);
         if (displayNameGenerationAnnotation != null) {
+
+
             DisplayNameGenerator nameGenerator = DisplayNameGenerator.getDisplayNameGenerator(testClass.getAnnotation(DisplayNameGeneration.class).value());
             return Optional.of(nameGenerator.generateDisplayNameForMethod(testClass, javaMethod));
         }
         return null;
     }
-}
+}