Skip to content

Commit

Permalink
Disable lazyfs test on arm64 machines
Browse files Browse the repository at this point in the history
Lazyfs adds additional overhead causing arm64 machines in CI to not reach robustness test qps requirements due to lack of compute power.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
  • Loading branch information
serathius committed Jan 25, 2024
1 parent 4d31082 commit 2d467e4
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/robustness-nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
artifactName: main
runs-on: "['ubuntu-latest-8-cores']"
scenario: TestRobustnessExploratory
lazyfsEnabled: true
main-arm64:
uses: ./.github/workflows/robustness-template.yaml
with:
Expand All @@ -30,6 +31,7 @@ jobs:
artifactName: main-arm64
runs-on: "['actuated-arm64-8cpu-8gb']"
scenario: TestRobustnessExploratory
lazyfsEnabled: false
release-35:
uses: ./.github/workflows/robustness-template.yaml
with:
Expand All @@ -39,6 +41,7 @@ jobs:
artifactName: release-35
runs-on: "['ubuntu-latest-8-cores']"
scenario: TestRobustnessExploratory
lazyfsEnabled: true
release-35-arm64:
uses: ./.github/workflows/robustness-template.yaml
with:
Expand All @@ -48,6 +51,7 @@ jobs:
artifactName: release-35-arm64
runs-on: "['actuated-arm64-8cpu-8gb']"
scenario: TestRobustnessExploratory
lazyfsEnabled: false
release-34:
uses: ./.github/workflows/robustness-template.yaml
with:
Expand All @@ -57,3 +61,4 @@ jobs:
artifactName: release-34
runs-on: "['ubuntu-latest-8-cores']"
scenario: TestRobustnessExploratory
lazyfsEnabled: true
13 changes: 9 additions & 4 deletions .github/workflows/robustness-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ on:
scenario:
required: true
type: string
lazyfsEnabled:
required: true
type: bool
permissions: read-all

jobs:
Expand All @@ -36,17 +39,19 @@ jobs:
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
with:
go-version: ${{ steps.goversion.outputs.goversion }}
- name: install-lazyfs
if: ${{ inputs.lazyfsEnabled }}
run: |
sudo apt update && sudo apt-get --yes install cmake libfuse3-dev libfuse3-3 fuse3
sudo sed -i 's/#user_allow_other/user_allow_other/g' /etc/fuse.conf
make install-lazyfs
- name: test-robustness
env:
ETCD_BRANCH: "${{ inputs.etcdBranch }}"
run: |
set -euo pipefail
go clean -testcache
# Build LazyFS
sudo apt update && sudo apt-get --yes install cmake libfuse3-dev libfuse3-3 fuse3
sudo sed -i 's/#user_allow_other/user_allow_other/g' /etc/fuse.conf
make install-lazyfs
# Use --failfast to avoid overriding report generated by failed test
GO_TEST_FLAGS="-v --count ${{ inputs.count }} --timeout ${{ inputs.testTimeout }} --failfast --run ${{ inputs.scenario }}"
case "${ETCD_BRANCH}" in
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/robustness.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
artifactName: main
runs-on: "['ubuntu-latest-8-cores']"
scenario: TestRobustness
lazyfsEnabled: true
main-arm64:
uses: ./.github/workflows/robustness-template.yaml
with:
Expand All @@ -21,3 +22,4 @@ jobs:
artifactName: main-arm64
runs-on: "['actuated-arm64-8cpu-8gb']"
scenario: TestRobustness
lazyfsEnabled: false

0 comments on commit 2d467e4

Please sign in to comment.