Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: aggregate v2 receipts into v2 rav #274

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

gusinacio
Copy link
Contributor

refactor!: move grpc structs to v1
refactor: create shared uint128 proto

Signed-off-by: Gustavo Inacio gustavo@semiotic.ai

@gusinacio gusinacio force-pushed the gustavo/tap-aggregator-horizon branch from 5ffe3f7 to 9e06705 Compare January 29, 2025 20:46
refactor!: move grpc structs to v1
refactor: create shared uint128 proto

Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gustavo/tap-aggregator-horizon branch from 9e06705 to 726b45d Compare January 29, 2025 20:46
@coveralls
Copy link

coveralls commented Jan 29, 2025

Pull Request Test Coverage Report for Build 13040122646

Details

  • 388 of 470 (82.55%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 78.431%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_aggregator/src/server.rs 43 46 93.48%
tap_aggregator/src/aggregator/v1.rs 93 98 94.9%
tap_aggregator/src/grpc.rs 140 169 82.84%
tap_aggregator/src/aggregator/v2.rs 112 157 71.34%
Totals Coverage Status
Change from base Build 13038535595: 1.1%
Covered Lines: 1320
Relevant Lines: 1683

💛 - Coveralls

@gusinacio gusinacio changed the title refactor!: add v2 proto feat!: aggregate v2 receipts into v2 rav Jan 29, 2025
Copy link
Contributor

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @gusinacio , would love for @carlosvdr to get to read through as well 🙏

@gusinacio gusinacio requested a review from carlosvdr January 30, 2025 18:43
@gusinacio gusinacio merged commit df70b82 into main Jan 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants