Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split read and write storage, update trait bounds and new mock feature flag #194

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Dec 14, 2023

  • split storage to read and write implementation
  • split the manager implementation for multiples trait bounds
  • don't ship mocks without feature flag

This comment has been minimized.

Copy link

github-actions bot commented Dec 14, 2023

Pull Request Test Coverage Report for Build 7222945878

  • 134 of 149 (89.93%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.555%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/adapters/mock/receipt_storage_adapter_mock.rs 17 20 85.0%
tap_core/src/tap_manager/manager.rs 57 62 91.94%
tap_core/src/tap_receipt/receipt_auditor.rs 60 67 89.55%
Totals Coverage Status
Change from base Build 7023423926: 0.0%
Covered Lines: 1273
Relevant Lines: 1542

💛 - Coveralls

This comment has been minimized.

@gusinacio gusinacio changed the title Gusinacio/split storage refactor: split read and write storage, update trait bounds and new mock feature flag Dec 14, 2023
@gusinacio gusinacio force-pushed the gusinacio/split-storage branch 2 times, most recently from aa3203b to 7e29cd9 Compare December 14, 2023 23:01

This comment has been minimized.

1 similar comment

This comment has been minimized.

Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/split-storage branch from 7e29cd9 to 2aa8877 Compare December 15, 2023 13:57
@gusinacio gusinacio enabled auto-merge December 15, 2023 13:58
@gusinacio gusinacio merged commit e9770f9 into main Dec 15, 2023
7 checks passed
Copy link

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants