docs: 📝 revise package guide to "local-first" #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
requested changes
Mar 6, 2025
docs/guide/packages.qmd
Outdated
|
|
||
| With that in mind, let's make our first data package! A data package | ||
| always needs a `datapackage.json` file. This file contains a set of | ||
| properties, or metadata, about the data package and, eventually, about |
There was a problem hiding this comment.
With the first mention of properties here, we could include a link to the glossary/definition.
There was a problem hiding this comment.
Yea, I want to make that glossary repo and than go through all our repos and link to the glossary. But that's later since we don't have that set up yet.
There was a problem hiding this comment.
For now, you could add a link to the glossary we currently have?
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
lwjohnst86
commented
Mar 6, 2025
| updated_package_properties = sp.edit_package_properties( | ||
| path=package_path, | ||
| sp.edit_package_properties( | ||
| path=sp.path_properties(path=package_path), |
There was a problem hiding this comment.
I realized this doesn't build now because it depends on #1114
lwjohnst86
commented
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To match our "local-first" approach.
Closes #1086
This PR needs an in-depth review.
Checklist
just run-all