-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: optimize unit test #492
Conversation
Song-Quan
commented
Mar 4, 2025
- Trigger unit tests based on the changed code
- Extract duplicate code as commands
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
pkg/.* run_unittest true | ||
.bazelrc run_unittest true | ||
.circleci/unittest-config.yml run_unittest true | ||
api/.* run_go_ut true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from run_unittest
to run_go_ut
seems reasonable given the PR title 'CI: optimize unit test'. However, could you elaborate on why the other mappings (bazel, cmd, engine, pkg, .bazelrc, .circleci/unittest-config.yml) were removed? Are these tests now covered under the run_go_ut
or are they being handled differently? Understanding the reasoning behind these removals will help ensure that the change doesn't inadvertently reduce test coverage.
@gemini-code-assist PTAL |
PTAL means 'Please Take A Look'. I will review the pull request now. |
@gemini-code-assist explain this PR |
The PR aims to optimize the unit test process by triggering tests based on changed code and extracting duplicate code into reusable commands. I'll provide a summary of the changes below:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jingshi-ant please take a final look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM