Create Prepare Release workflow #370
Merged
+209
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
approved these changes
Jan 9, 2025
scripts/release_notes_generator.py
Outdated
| def _create_release_notes(issues_by_category, version, date): | ||
| title = f'## v{version} - {date}' | ||
| release_notes = f'{title}{NEW_LINE}{NEW_LINE}' | ||
| for category in ISSUE_LABELS + ['misc']: |
There was a problem hiding this comment.
SDV-Enterprise uses another list here.
It also has this extra line:
# Filter our PRs
issues_on_page = [issue for issue in issues_on_page if issue.get('pull_request') is None]
There was a problem hiding this comment.
@R-Palazzo do these changes need to be propagated to any other libraries?
There was a problem hiding this comment.
Good catch, thanks @fealho.
Yes, if we want to use what's in Enterprise, SDMetrics and SDGym must be updated (other libraries already have the changes)
I have a PR on both libraries that are related so I will include the changes @amontanez24
amontanez24
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b2xrf9c
Resolve #364