Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Evaporative Humidifier #296

Merged
merged 26 commits into from
Mar 1, 2025

Conversation

dsypniewski
Copy link
Contributor

@dsypniewski dsypniewski commented Feb 2, 2025

This adds support for Evaporative Humidifier (without docking station) in preparation to start working on HA integration.

@dsypniewski dsypniewski marked this pull request as draft February 2, 2025 11:57
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 91.94631% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
switchbot/devices/evaporative_humidifier.py 91.96% 9 Missing ⚠️
switchbot/discovery.py 25.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
switchbot/__init__.py 100.00% <100.00%> (ø)
switchbot/adv_parser.py 93.33% <100.00%> (ø)
switchbot/adv_parsers/humidifier.py 84.21% <100.00%> (+27.06%) ⬆️
switchbot/const/__init__.py 100.00% <100.00%> (ø)
switchbot/const/evaporative_humidifier.py 100.00% <100.00%> (ø)
switchbot/discovery.py 35.13% <25.00%> (-0.58%) ⬇️
switchbot/devices/evaporative_humidifier.py 91.96% <91.96%> (ø)

@bdraco
Copy link
Member

bdraco commented Feb 2, 2025

Or maybe should I do this in this PR as well?

It would be best to do a PR to extract them first, than we can back merge it into this PR which would make it a lot easier to review since it would minimize the amount of code changes

@dsypniewski dsypniewski marked this pull request as ready for review February 11, 2025 06:56
@bdraco
Copy link
Member

bdraco commented Feb 12, 2025

I noticed a few things that the linter wasn't picking up when doing the review so I turned on some more rules that would catch these automatically as its likely easier than having to wait for me to review.

I think this is ready to go once the issues ruff has found are addressed.

@dsypniewski dsypniewski requested a review from bdraco February 12, 2025 22:32
@dsypniewski
Copy link
Contributor Author

I think this should be good to go

@bdraco bdraco merged commit 98b42dc into sblibs:master Mar 1, 2025
5 checks passed
@bdraco
Copy link
Member

bdraco commented Mar 1, 2025

Thanks @dsypniewski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants