fix DeprecationWarning: Attribute s is deprecated and will be removed… #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2926 +/- ##
=============================================
- Coverage 88.134% 88.014% -0.120%
=============================================
Files 94 94
Lines 7408 7409 +1
Branches 1307 1307
=============================================
- Hits 6529 6521 -8
- Misses 592 598 +6
- Partials 287 290 +3 ☔ View full report in Codecov by Sentry. |
ahopkins
requested changes
Mar 24, 2024
hamedsh
force-pushed
the
fix-Deprecation-warning
branch
from
7ed8403 to
9ff3ba6
Compare
added 2 commits
March 25, 2024 09:32
… in Python 3.14; use value instead The attribute check within the 'ode.py' script has been updated. Previously, it checked whether the event has an attribute 's', however, this has been modified to check for the 'value' attribute instead. This ensures the correct attribute is being checked for the ongoing processes.
Adjusted a condition in 'ode.py' to handle changes in sys.version_info from 3.12 onwards. This fix ensures compatibility with newer Python versions as system requirements are now checked before the execution of certain commands.
hamedsh
force-pushed
the
fix-Deprecation-warning
branch
from
9ff3ba6 to
8ca200b
Compare
ahopkins
approved these changes
Apr 1, 2024
|
Thanks for the contribution. I went a slightly different route: #2959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in Python 3.14; use value instead
The attribute check within the 'ode.py' script has been updated. Previously, it checked whether the event has an attribute 's', however, this has been modified to check for the 'value' attribute instead. This ensures the correct attribute is being checked for the ongoing processes.