Gas Metering for Deployment & Token Operation

[remedcu]

To Do:

• Tests within 4337 folder for checking gas usage.
• Alchemy Based Gas Usage for Safe 4337 (Paymaster with/out Gas Policy).
• Pimlico Based Gas Usage for Safe 4337 (Paymaster with/out Gas Policy).
• Gelato Based Gas Usage for Safe 4337 (With 1Balance).
• Detailed analysis of Gas for each section of the TX Lifecycle.

Closes #170

[coveralls]

Pull Request Test Coverage Report for Build 7287608968

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 13.547%

---

Totals
Change from base Build 7287161487:	0.0%
Covered Lines:	33
Relevant Lines:	282

---

💛 - Coveralls

[nlordell]

For the paymaster, do you think it would be possible to vendor the Pimlico and Alchemy paymaster code into the repo? Would make future tests (including paymasters) easier to compute.

[remedcu]

I won't suggest adding those codes as it uses "type": "module" for package.json, which is not compatible with our current setup.

[nlordell]

I won't suggest adding those codes as it uses "type": "module" for package.json, which is not compatible with our current setup.

Would it work if we just imported the contracts and not the JS source (assuming they build with Solidity v0.8.23)?

[remedcu]

It is done purely with Typescript and onchain deployed contracts.

Most of the code taken from: https://github.com/schmanu/poc-safe-erc20-paymaster

[mmv08]

A question:

I wanted to compare the numbers to https://github.com/zerodevapp/aa-benchmark/pull/10/files, but I found no transfer benchmarks without a paymaster and not while deploying. Should we implement that, or perhaps I just looked at the wrong place?

[remedcu]

I wanted to compare the numbers to https://github.com/zerodevapp/aa-benchmark/pull/10/files, but I found no transfer benchmarks without a paymaster and not while deploying. Should we implement that, or perhaps I just looked at the wrong place?

I believe you are asking for this one: https://github.com/safe-global/safe-modules/blob/gas-metering/4337/test/gas/Gas.spec.ts#L137

For deployment and operations without paymaster, that is implemented within this folder: https://github.com/safe-global/safe-modules/tree/gas-metering/4337/test/gas

[mmv08]

I wanted to compare the numbers to https://github.com/zerodevapp/aa-benchmark/pull/10/files, but I found no transfer benchmarks without a paymaster and not while deploying. Should we implement that, or perhaps I just looked at the wrong place?

I believe you are asking for this one: https://github.com/safe-global/safe-modules/blob/gas-metering/4337/test/gas/Gas.spec.ts#L137

For deployment and operations without paymaster, that is implemented within this folder: https://github.com/safe-global/safe-modules/tree/gas-metering/4337/test/gas

Are the results written down somewhere?

[remedcu]

Right now on the first comment of this PR: #175 (comment)

But once I change to v0.2 of Module for the paymaster once as well, will have all the gas values in the README, like this: https://github.com/safe-global/safe-modules/tree/gas-metering/4337-gas-metering

[nlordell]

It would be nice to setup some CI for the gas-metering workspace package. In particular, just doing:

• Prettier formatting check
• ESLint check
• TSC compile check

Not blocking the PR though.

[nlordell]

LGTM