Fix GameMessage header (#1790)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Refactor**
- Improved game message handling and version identification for enhanced
compatibility and reliability.
- **New Features**
- Updated game message serialization process to support multiple
versions, ensuring a smoother gaming experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

package.json

@@ -30,6 +30,7 @@
     "dependencies": {
         "@rustymotors/database": "workspace:^",
         "@rustymotors/shared": "workspace:^",
+        "@rustymotors/shared-packets": "workspace:^",
         "@sentry/node": "^7.102.0",
         "@sentry/profiling-node": "^7.104.0",
         "slonik": "29",

packages/gateway/package.json

@@ -13,6 +13,7 @@
     "dependencies": {
         "@fastify/sensible": "^5.5.0",
         "@rustymotors/shared": "workspace:^",
+        "@rustymotors/shared-packets": "workspace:^",
         "@sentry/node": "^7.102.0",
         "fastify": "^4.25.2"
     }

packages/gateway/src/index.ts

@@ -33,11 +33,12 @@ import {
     MessageProcessorError,
     getGameMessageProcessor,
     getPortMessageType,
-    GameMessage,
+    GameMessage as OldGameMessage,
 } from "../../nps/index.js";
 import { SocketCallback } from "../../nps/messageProcessors/index.js";
 import { getAsHex } from "../../nps/utils/pureGet.js";
 import { ServiceResponse } from "@rustymotors/shared";
+import { GameMessage } from "@rustymotors/shared-packets";
 
 /**
  * @typedef {object} OnDataHandlerArgs
@@ -244,7 +245,7 @@ function sendToSocket(
 
 export function processGameMessage(
     connectionId: string,
-    message: GameMessage,
+    message: OldGameMessage,
     log: ServerLogger,
     socketCallback: SocketCallback,
 ) {
@@ -279,16 +280,24 @@ export function handleGameMessage(
     // Log raw bytes
     log.trace(`Raw bytes: ${bytes.toString("hex")}`);
 
+    // Since a GameMessage v1 header is 12 byes long, a message smaller that that can only be v0
+    const msgVersion = bytes.byteLength <= 12 ? 0 : 1;
+
+    // Load new game message    
+    const gameMessage = new GameMessage(msgVersion).deserialize(bytes);
+
+    log.debug(`Game message: ${gameMessage}`);
+
     // Try to identify the message version
-    const version = GameMessage.identifyVersion(bytes);
+    const version = OldGameMessage.identifyVersion(bytes);
 
     // Log the version
     log.debug(`Message version: ${version}`);
 
     // Try to parse it
     try {
         // Create a new message
-        const message = new GameMessage(version);
+        const message = new OldGameMessage(version);
         message.deserialize(bytes);
 
         // Process the message

packages/shared-packets/index.ts

@@ -1 +1,2 @@
 export * from "./src/interfaces.js";
+export {GameMessage } from "./src/GameMessage.js";

packages/shared-packets/package.json

@@ -3,7 +3,13 @@
     "private": true,
     "version": "1.0.0",
     "description": "",
-    "main": "index.js",
+    "type": "module",
+    "exports": {
+        ".": {
+            "import": "./index.ts",
+            "require": "./index.ts"
+        }
+    },
     "scripts": {
         "build": "rm -rf dist && tsc",
         "test": "echo \"Error: no test specified\" && exit 1"

packages/shared-packets/src/GameMessage.ts

@@ -35,11 +35,11 @@ export class GameMessageHeader extends Serializable implements ISerializable {
     getLength(): number {
         return this.length;
     }
-    setVersion(version: 0 | 257): void {
-        if (version !== 0 && version !== 257) {
+    setVersion(version: 0 | 1): void {
+        if (version !== 0 && version !== 1) {
             throw new Error(`Invalid version: ${version}`);
         }
-        this.version = version;
+        this.version = version === 0 ? 0 : 257;
     }
     setId(id: number): void {
         this.id = id;
@@ -151,9 +151,7 @@ export class GameMessage extends Serializable implements IMessage {
     }
 
     override toString(): string {
-        return `Id: ${this.header.getId()} 
-        Length: ${this.header.getLength()} 
-        Data: ${this.data.toString()}`;
+        return `Id: ${this.header.getId()}, Length: ${this.header.getLength()}, Data: ${this.data.asHexString()}`;
     }
 
     static identifyVersion(data: Buffer): 0 | 257 {