-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not yeet unsafe<>
from type when formatting unsafe binder
#137769
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
Cannot remember if you have r+, so @bors delegate=ymtimi |
✌️ @ymtimi, you can now approve this pull request! If @compiler-errors told you to " |
unsafe<>
from type when formatting unsafe binder
@bors r+ |
@ytmimi: 🔑 Insufficient privileges: Not in reviewers |
:/// I typoed your name in the delegate. sorry! @bors r=ytmimi |
All good. This was a nice and simple PR! |
Do you know who I need to reach out to in order to get the right privileges to approve PRs? |
T-rustfmt should definitely have bors permissions in this repo, at least with the understanding that the permissions will only be used for rustfmt subtree syncs and the occasional in-tree rustfmt PR. You should open a teams PR that adds these lines to
|
Unsafe binders are types like
unsafe<'a, 'b> Ty<'a, 'b>
. However, users can also specify unsafe binder types with no bound vars, likeunsafe<> Ty
.When I added nightly formatting for unsafe binders, I didn't consider this, so on nightly we are stripping the
unsafe<>
part, which gives us backTy
which is a different type!This PR fixes that.
r? @ytmimi