Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 9 pull requests #137065

Merged
merged 21 commits into from
Feb 15, 2025
Merged

Rollup of 9 pull requests #137065

merged 21 commits into from
Feb 15, 2025

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Feb 15, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joseluis and others added 21 commits January 18, 2025 16:35
@joseluis
re-export core::iter::FromCoroutine
f02c3f8
@mzeitlin11
Implement Extend<AsciiChar> for String
d566b5d
@ChrisDenton
Windows: Update generated bindings to 0.59
26eeac1
@marcoieni
CI: split i686-mingw job to three free runners
00683a0
@kornelski
Add safe new to NotAllOnes
00964aa
@Zalathar
Rename PatCtxt::lower_lit to lower_pat_expr
1284765 
This matches the HIR changes in rust-lang#134228, which introduced `PatExpr` to hold the
subset of "expressions" that can appear in a pattern.
@Zalathar
Clarify control-flow in lower_path
c3eea53
@Zalathar
More comments for lower_inline_const
92fc085
@chenyukang
Remove unnecessary check code in unused_delims
b2197ab
@geetanshjuneja
made check_argument_compat public
f3fa720
@thaliaarchi
Forward all default methods for I/O impls
11c1740
@RalfJung
add a doc comment
8769d03
@jhpratt
Rollup merge of rust-lang#135687 - joseluis:feat-reexport_from_corout…
afbeefb 
…ine, r=scottmcm

re-export `FromCoroutine` from `core::iter`

tracking issue: rust-lang#43122
fixes: rust-lang#135686
@jhpratt
Rollup merge of rust-lang#135813 - marcoieni:free-runner-i686-mingw, …
92adb92 
…r=jdno

CI: split i686-mingw job to three free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
try-job: x86_64-mingw-1
@jhpratt
Rollup merge of rust-lang#136749 - mzeitlin11:extend-asciichar, r=sco…
26be558 
…ttmcm

Implement Extend<AsciiChar> for String

Implement `Extend<AsciiChar>` for `String` as suggested in rust-lang#110998 (comment). Also implements `Extend<&AsciiChar>` since there's an analogous impl for `Extend<&char>`, but happy to remove if not thought useful.

r? `@scottmcm`
since you requested it, but no pressure to review!
@jhpratt
Rollup merge of rust-lang#136879 - kornelski:non1, r=Noratrieb
1524b53 
Add safe new() to NotAllOnes

Replaces duplicated `unsafe` code with a single, easier to verify implementation.
@jhpratt
Rollup merge of rust-lang#136978 - ChrisDenton:windows-bindgen, r=Ama…
224be79 
…nieu

Windows: Update generated bindings

Update to windows-bindgen 0.59.

This update is aimed at reducing churn in the future, but means a bit more churn now:

- `bindings.txt` no longer needs us to write the namespace for each item. This is good because it means in the future we won't need to change them if the namespace changes. However, there are a few where we still need to disambiguate due to duplicate items (this is a bug in the upstream metadata).
- The output in `windows-sys.rs` is now sorted. It was mostly sorted before but not intentionally. This should mean future changes are less noisy.

The actual code changes are minimal here. A few types are now `bool` instead of `BOOLEAN`, which is more convenient.
@jhpratt
Rollup merge of rust-lang#137028 - Zalathar:thir-pat-expr, r=compiler…
c133123 
…-errors

mir_build: Clarify some code for lowering `hir::PatExpr` to THIR

A few loosely-related improvements to the code that lowers certain parts of HIR patterns to THIR.

I was originally deferring this until after rust-lang#136529, but that PR probably won't happen, whereas these changes should hopefully be uncontroversial.

r? Nadrieril or reroll
@jhpratt
Rollup merge of rust-lang#137029 - chenyukang:yukang-fix-unused-check…
221ba2d 
…, r=jieyouxu,compiler-errors

Remove unnecessary check code in unused_delims

After PR rust-lang#108297, we make sure there is no unmatched delims in early lint check.
@jhpratt
Rollup merge of rust-lang#137056 - geetanshjuneja:pub, r=RalfJung
6593a25 
made check_argument_compat public for use in miri

Links to [issue](rust-lang/miri#3842) and it's [PR](rust-lang/miri#4185 (comment))  in miri.
@jhpratt
Rollup merge of rust-lang#137062 - thaliaarchi:io-optional-methods/wr…
ba89ea8 
…ite, r=workingjubilee

Forward all default methods for I/O impls

Forward all default methods for `&mut T` and `Box<T>` to the inner `io::Read`, `io::Write`, `io::Seek`, and `io::BufRead` types.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-solid Operating System: SOLID O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 15, 2025
@jhpratt
Copy link
Member Author

jhpratt commented Feb 15, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Feb 15, 2025

📌 Commit ba89ea8 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2025
@bors
Copy link
Contributor

bors commented Feb 15, 2025

⌛ Testing commit ba89ea8 with merge 8c07d14...

@bors
Copy link
Contributor

bors commented Feb 15, 2025

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 8c07d14 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 15, 2025
@bors bors merged commit 8c07d14 into rust-lang:master Feb 15, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 15, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#135687 re-export FromCoroutine from core::iter a23670ecf3bdd71c1f02d3cf55e6da8d00c860cc (link)
#135813 CI: split i686-mingw job to three free runners 924cb5649076e91f181c82455bbc8d413764b7e8 (link)
#136749 Implement Extend for String 602e5630c152473fbb45cd879cb107df5d720069 (link)
#136879 Add safe new() to NotAllOnes 12f284ee923662d4e1f59721ccd4352de8f875c7 (link)
#136978 Windows: Update generated bindings ebc2b1aec61b7fe7fc4110711b9bcb0fcfc071cd (link)
#137028 mir_build: Clarify some code for lowering hir::PatExpr to… 127c835ba0534b7d67d3e7c87d082b4ab49567b4 (link)
#137029 Remove unnecessary check code in unused_delims d450a6ef22055edcec41d42874720e2de97899b5 (link)
#137056 made check_argument_compat public for use in miri 0ac7cc1daacbe6fb08960039322a1e69f0d33bd7 (link)
#137062 Forward all default methods for I/O impls e60faad3960462418915c2e6f7a543eda277390a (link)

previous master: f77247ac59

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Feb 15, 2025
Open
Open
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8c07d14): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.2% [2.5%, 3.8%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -5.6% [-5.6%, -5.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [-5.6%, 3.8%] 3

Cycles

Results (secondary -8.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -8.8% [-9.3%, -8.5%] 6
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.0%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.1%] 5
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 34
Improvements ✅
(primary)		 -0.0% [-0.1%, -0.0%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.0% [-0.1%, 0.1%] 7

Bootstrap: 788.977s -> 790.255s (0.16%)
Artifact size: 347.33 MiB -> 347.22 MiB (-0.03%)

@jhpratt jhpratt deleted the rollup-ree9mej branch February 16, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-solid Operating System: SOLID O-windows Operating system: Windows rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.