fix: overflowing bin hex

[11happy]

Overview:

• This PR fixes Wrong type suggested in overflowing_bin_hex #135404.

Testing

• Tested the updated functionality.
• previously emitted diagnostics:

error: literal out of range for `i32`
 --> src/main.rs:2:9
  |
2 |     _ = 0x8FFF_FFFF_FFFF_FFFE;
  |         ^^^^^^^^^^^^^^^^^^^^^
  |
  = note: the literal `0x8FFF_FFFF_FFFF_FFFE` (decimal `10376293541461622782`) does not fit into the type `i32` and will become `-2i32`
  = help: consider using the type `i128` instead
  = note: `#[deny(overflowing_literals)]` on by default
help: to use as a negative number (decimal `-2`), consider using the type `u32` for the literal and cast it to `i32`
  |
2 |     _ = 0x8FFF_FFFF_FFFF_FFFEu32 as i32;
  |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

• current diagnostics:

error: literal out of range for `i32`
 --> ../temp.rs:2:13
  |
2 |     let x = 0x8FFF_FFFF_FFFF_FFFE;
  |             ^^^^^^^^^^^^^^^^^^^^^
  |
  = note: the literal `0x8FFF_FFFF_FFFF_FFFE` (decimal `10376293541461622782`) does not fit into the type `i32` and will become `-2i32`
  = help: consider using the type `u64` instead
  = note: `#[deny(overflowing_literals)]` on by default
help: to use as a negative number (decimal `-2`), consider using the type `u64` for the literal and cast it to `i32`
  |
2 |     let x = 0x8FFF_FFFF_FFFF_FFFEu64 as i32;
  |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @fmease (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[s-cerevisiae]

You are expected to fix the test affected by your change, in this case tests/ui/lint/type-overflow.rs.

Please refer to the rustc dev guide for instructions on how to write, run and change test files.

Btw I left a //~| HELP case empty in line 44 of that file because of the issue you are fixing, you may add the corresponding overflowing_bin_hex help message there so that it's fully tested :3

[vayunbiyani]

@11happy I added a PR to bless the test case, you could please merge it?

[11happy]

@s-cerevisiae I have fixed the test case & added another one as well wherer earlier response was incorrect.
Thank you

[11happy]

@vayunbiyani you could perhaps ask the respective maintainers to merge your corresponding PR, I don't have merge rights.
Thank you

[vayunbiyani]

The PR is on your fork so you should be good to do so!

[11happy]

The PR is on your fork so you should be good to do so!

Thank you for the PR I have integrated those changes.

[bors]

☔ The latest upstream changes (presumably #127541) made this pull request unmergeable. Please resolve the merge conflicts.

[11happy]

Humble Ping! @s-cerevisiae I have also fixed the merge conflict.
Thank you

[fmease]

@11happy The CI is failing because #136958 & #137348 tweaked the appearance of certain structured suggestions. You simply need to rebase & rebless tests/ui/lint/type-overflow.rs (e.g., via ./x t tests/ui/lint/type-overflow.rs --bless if you're on Linux (see the rustc dev guide for more options)).

Please also squash the two commits into a single one (since the diff is pretty small).

The Signed-off-by field is okay (tho it doesn't bear any specific meaning in the Rust project IINM). Regarding @vayunbiyani's patch you incorporated, I was a bit surprised to see the original authorship information removed. I'm not entirely sure if authorship attribution is necessary in this specific case since the change by [@]vayunbiyani is likely to be considered trivial wrt. to copyright law (IANAL). Anyway, no big deal but you could consider using Co-authored-by: in such cases in the future :)

Humble Ping! [@]s-cerevisiae I have also fixed the merge conflict.

([@]s-cerevisiae is not an official r-l/r reviewer)

[fmease]

After that though, we're good to go! Thanks for working on this

[11happy]

Thanks @fmease , I have reblessed & rebased the commits as well. Thank you for providing me opportunity to work on this, I am new to this rust community, interested to learn & contribute.

[fmease]

Thank you and welcome!
@bors r+ rollup

[bors]

📌 Commit dbf8fe0 has been approved by fmease

It is now in the queue for this repository.