Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import initial generated 1.85 relnotes #135797

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Import initial generated 1.85 relnotes #135797

merged 1 commit into from
Feb 16, 2025

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum changed the title Import initial generated relnotes Import initial generated 1.85 relnotes Jan 20, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jan 20, 2025
@cuviper
Copy link
Member

cuviper commented Jan 27, 2025

@rustbot ping relnotes-interest-group

@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2025

Hi relnotes-interest-group, this PR adds release notes. Could you review this PR
if you have time? Thanks <3

cc @alex-semenyuk @jieyouxu @joshtriplett @traviscross

@tmandry
Copy link
Member

tmandry commented Jan 28, 2025

r? rust-lang/release

No longer on the release team :).

@rustbot rustbot assigned pietroalbini and unassigned tmandry Jan 28, 2025
jieyouxu
jieyouxu reviewed Jan 28, 2025
View reviewed changes
alex-semenyuk
alex-semenyuk reviewed Jan 28, 2025
View reviewed changes
alex-semenyuk
alex-semenyuk reviewed Jan 28, 2025
View reviewed changes
@bors
Copy link
Contributor

bors commented Jan 31, 2025

☔ The latest upstream changes (presumably #136318) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member Author

Most feedback is incorporated that could be without editing outside of the generator's inputs (i.e., rust-lang/rust tracking issues).

joshtriplett
joshtriplett reviewed Feb 3, 2025
View reviewed changes
RELEASES.md Outdated
- [Add `unpredictable_function_pointer_comparisons` lint to warn against function pointer comparisons](https://github.com/rust-lang/rust/pull/118833)
- [Lint on combining `#[no_mangle]` and `#[export_name]` attributes.](https://github.com/rust-lang/rust/pull/131558)
- [Stabilize `#[diagnostic::do_not_recommend]`](https://github.com/rust-lang/rust/pull/132056)
- [Stabilize async closures](https://github.com/rust-lang/rust/pull/132706)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should appear in the blog post.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should probably appear second in the list, after the edition.

joshtriplett
joshtriplett reviewed Feb 3, 2025
View reviewed changes
RELEASES.md Outdated
This stabilizes usage of `...` variable args in extern declarations for `system`, `aapcs`, `sysv64`, `win64`, and `efiapi` calling conventions. `C` and `cdecl` were previously stable.
- [Add `unpredictable_function_pointer_comparisons` lint to warn against function pointer comparisons](https://github.com/rust-lang/rust/pull/118833)
- [Lint on combining `#[no_mangle]` and `#[export_name]` attributes.](https://github.com/rust-lang/rust/pull/131558)
- [Stabilize `#[diagnostic::do_not_recommend]`](https://github.com/rust-lang/rust/pull/132056)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is worth a brief mention in the blog post.

joshtriplett
joshtriplett reviewed Feb 3, 2025
View reviewed changes
pthariensflame
pthariensflame reviewed Feb 13, 2025
View reviewed changes
RELEASES.md
- [Unsigned `{integer}::midpoint`](https://doc.rust-lang.org/std/primitive.u64.html#method.midpoint)
- [`NonZeroU*::midpoint`](https://doc.rust-lang.org/std/num/type.NonZeroU32.html#method.midpoint)
- [impl `std::iter::Extend` for tuples with arity 1 through 12](https://doc.rust-lang.org/stable/std/iter/trait.Extend.html#impl-Extend%3C(A,)%3E-for-(EA,))
- [`FromIterator<(A, ...)>` for tuples with arity 1 through 12](https://doc.rust-lang.org/stable/std/iter/trait.FromIterator.html#impl-FromIterator%3C(EA,)%3E-for-(A,))
Copy link
Contributor

@pthariensflame pthariensflame Feb 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines about tuples in collect/extend should probably get a mention in the blog post; that’s effectively a new major feature from the perspective of people “just using” Rust iterators!

cuviper
cuviper reviewed Feb 13, 2025
View reviewed changes
Urgau
Urgau reviewed Feb 15, 2025
View reviewed changes
@Urgau Urgau mentioned this pull request Feb 15, 2025
Open
@Mark-Simulacrum
Copy link
Member Author

Squashed. @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 15, 2025

📌 Commit 8aa2290 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2025
@jhpratt jhpratt mentioned this pull request Feb 16, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
@bors
Auto merge of rust-lang#137111 - jhpratt:rollup-izd98sx, r=jhpratt
4229b80 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#135797 (Import initial generated 1.85 relnotes)
 - rust-lang#135909 (Export kernel descriptor for amdgpu kernels)
 - rust-lang#136545 (nvptx64: update default alignment to match LLVM 21)
 - rust-lang#137092 (abi_unsupported_vector_types: say which type is the problem)
 - rust-lang#137097 (Ignore Self in bounds check for associated types with Self:Sized)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aa37d79 into rust-lang:master Feb 16, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
@rust-timer
Unrolled build for rust-lang#135797
f5744b6 
Rollup merge of rust-lang#135797 - Mark-Simulacrum:relnotes, r=Mark-Simulacrum

Import initial generated 1.85 relnotes

https://forge.rust-lang.org/release/release-notes.html#release-team-step-5-publish-relnotes-pr

r? rust-lang/release
@Urgau Urgau mentioned this pull request Feb 16, 2025
Merged
@Mark-Simulacrum Mark-Simulacrum deleted the relnotes branch February 16, 2025 21:04
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 16, 2025
@workingjubilee
Rollup merge of rust-lang#137125 - Urgau:reapply-empty-lines-relnotes…
72e63f6 
…, r=Mark-Simulacrum

Re-add missing empty lines in the releases notes

cf. rust-lang#135797 (comment) and https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/1.2E85/near/499937064
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 17, 2025
@matthiaskrgr
Rollup merge of rust-lang#137125 - Urgau:reapply-empty-lines-relnotes…
18e0746 
…, r=Mark-Simulacrum

Re-add missing empty lines in the releases notes

cf. rust-lang#135797 (comment) and https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/1.2E85/near/499937064
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2025
@rust-timer
Unrolled build for rust-lang#137125
ff613ec 
Rollup merge of rust-lang#137125 - Urgau:reapply-empty-lines-relnotes, r=Mark-Simulacrum

Re-add missing empty lines in the releases notes

cf. rust-lang#135797 (comment) and https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/1.2E85/near/499937064
github-merge-queue bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Feb 24, 2025
@matthiaskrgr
Rollup merge of #137125 - Urgau:reapply-empty-lines-relnotes, r=Mark-…
7229544 
…Simulacrum

Re-add missing empty lines in the releases notes

cf. rust-lang/rust#135797 (comment) and https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/1.2E85/near/499937064
@jieyouxu jieyouxu mentioned this pull request Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

@joshtriplett joshtriplett joshtriplett left review comments

@traviscross traviscross traviscross left review comments

@pthariensflame pthariensflame pthariensflame left review comments

@Urgau Urgau Urgau left review comments

@alex-semenyuk alex-semenyuk alex-semenyuk left review comments

@tgross35 tgross35 tgross35 left review comments

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@pietroalbini pietroalbini

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.